sdomde213606 (Community Member) asked a question.
List<String> commandList = Arrays.asList(commandArray);
ProcessBuilder pb = new ProcessBuilder(commandList);
Process process = pb.start();
Getting error at 2nd line ProcessBuilder(commandList);
Ask the Community
Get answers, share a use case, discuss your favorite features, or get input from the community.
By clicking “Accept All Cookies”, you agree to the storing of cookies on your device to enhance site navigation, analyze site usage, and assist in our marketing efforts.
.png){kind=logo}
These cookies are necessary for the website to function and cannot be switched off in our systems. They are usually only set in response to actions made by you which amount to a request for services, such as setting your privacy preferences, logging in or filling in forms. You can set your browser to block or alert you about these cookies, but some parts of the site will not then work. These cookies do not store any personally identifiable information.
These cookies allow us to count visits and traffic sources so we can measure and improve the performance of our site. They help us to know which pages are the most and least popular and see how visitors move around the site. All information these cookies collect is aggregated and therefore anonymous. If you do not allow these cookies we will not know when you have visited our site, and will not be able to monitor its performance.
These cookies may be set through our site by our advertising partners. They may be used by those companies to build a profile of your interests and show you relevant adverts on other sites. They do not store directly personal information, but are based on uniquely identifying your browser and internet device. If you do not allow these cookies, you will experience less targeted advertising.
Hi @sdomde213606 (Community Member),
Thanks for your question.
The flaw is being raised because the commandArray parameter contains data from an untrusted source, such as an HTTP request, a configuration file or database. Where possible the recommendation is to not allow the end user or consumer of the service to arbitrarily specify the executable or it's parameters to prevent malicious input from being injected and executed. If you must rely on data from untrusted sources, sufficient validation must be in place such as the use of allow-lists to mitigate the flaw.
I answered a similar question to this yesterday which may be useful for you: https://community.veracode.com/s/question/0D52T000054VCt8SAG/whats-causing-an-os-command-injectioncwe78-flaw-in-the-following-c-code.
Please note that Veracode Static Analysis is unable to verify the changes you have made sufficiently remove the risk from taking untrusted user input and executing it. The resolution for each instance is contextual to how the application processes the untrusted input, and so you will always be required to propose a mitigation. Such proposal should clearly state all the controls in place to mitigate the risk.
I hope that answers your question.
Thanks,
Anthony Fielding