srathore (Community Member) asked a question.
def output(
storedFile: StoredFile,
outputStream: OutputStream
): Unit = {
Files.copy(files(storedFile.getPath), outputStream)
()
}
This call to java.nio.file.Files.copy() causing the issue of CWE 80? How can I fix this?
Ask the Community
Get answers, share a use case, discuss your favorite features, or get input from the community.
By clicking “Accept All Cookies”, you agree to the storing of cookies on your device to enhance site navigation, analyze site usage, and assist in our marketing efforts.
.png){kind=logo}
These cookies are necessary for the website to function and cannot be switched off in our systems. They are usually only set in response to actions made by you which amount to a request for services, such as setting your privacy preferences, logging in or filling in forms. You can set your browser to block or alert you about these cookies, but some parts of the site will not then work. These cookies do not store any personally identifiable information.
These cookies allow us to count visits and traffic sources so we can measure and improve the performance of our site. They help us to know which pages are the most and least popular and see how visitors move around the site. All information these cookies collect is aggregated and therefore anonymous. If you do not allow these cookies we will not know when you have visited our site, and will not be able to monitor its performance.
These cookies may be set through our site by our advertising partners. They may be used by those companies to build a profile of your interests and show you relevant adverts on other sites. They do not store directly personal information, but are based on uniquely identifying your browser and internet device. If you do not allow these cookies, you will experience less targeted advertising.
Hi @srathore (Community Member),
Veracode Static Analysis reports CWE 80 (XSS) when it can detect that data from outside the application (such as the HTTP request, the database, or the filesystem) flows into functionality that may render HTML in a web browser. The concern is that an attacker might be able to inject their own HTML which might allow executing arbitrary JavaScript in the web browsers of your application's users.
In your particular example, I see a file is copied into an output stream. If the incoming file is user-controlled and the output stream would go to a web browser, an attacker might be able to inject an XSS payload into the file. This payload may then be rendered in a victim's web browser subsequently.
If the output stream goes to a web browser and the file contains e.g. text to be rendered in a web browser, please make sure to apply context-appropriate encoding using one of our supported cleansing functions (https://help.veracode.com/r/review_cleansers). This would make the flaw automatically disappear.
If the output stream goes to a web browser as a file download, please make sure to set a safe content type, the `Content-Disposition` header with a `filename`, as well as the `X-Content-Type-Options: nosniff` header. Please refer to the following Community response for more information on this: https://community.veracode.com/s/question/0D53n00008A802aCAB/fix-cwe-80improper-neutralization-of-scriptrelated-html-tags-in-a-web-page-basic-xssin-binary-data .
If the output stream does not go to a web browser, this finding can likely be mitigated. For this, you would have to propose a mitigation and discuss it with your Security Team. To know more about how to propose a mitigation, please refer to the following: https://help.veracode.com/r/improve_mitigation .
Thank you,
Florian Walter