
pbala857293 (Community Member) asked a question.
Have been facing "OS Command Injection" flaw category for the code segment "open NEW, "> $new_file";" in PERL file .
Any help/ suggestion is appreciated

pbala857293 (Community Member) asked a question.
Have been facing "OS Command Injection" flaw category for the code segment "open NEW, "> $new_file";" in PERL file .
Any help/ suggestion is appreciated
Ask the Community
Get answers, share a use case, discuss your favorite features, or get input from the community.
By clicking “Accept All Cookies”, you agree to the storing of cookies on your device to enhance site navigation, analyze site usage, and assist in our marketing efforts.
.png)
These cookies are necessary for the website to function and cannot be switched off in our systems. They are usually only set in response to actions made by you which amount to a request for services, such as setting your privacy preferences, logging in or filling in forms. You can set your browser to block or alert you about these cookies, but some parts of the site will not then work. These cookies do not store any personally identifiable information.
These cookies allow us to count visits and traffic sources so we can measure and improve the performance of our site. They help us to know which pages are the most and least popular and see how visitors move around the site. All information these cookies collect is aggregated and therefore anonymous. If you do not allow these cookies we will not know when you have visited our site, and will not be able to monitor its performance.
These cookies may be set through our site by our advertising partners. They may be used by those companies to build a profile of your interests and show you relevant adverts on other sites. They do not store directly personal information, but are based on uniquely identifying your browser and internet device. If you do not allow these cookies, you will experience less targeted advertising.
Hi @pbala857293 (Community Member),
I would recommend against calling `open()` with 2 parameters and, instead, use the better 3 parameter way (for more information on this, you may want to check out this: https://perlmaven.com/open-files-in-the-old-way). By doing this, you ensure that the operation mode is hardcoded and cannot be tampered with. This also prevents potential attack vectors aiming to append OS commands to the filename e.g. via semicolons. Using the 3 parameter way (e.g. `open my $in, '>', $filename or die ...;`) is the most effective measure against OS Command Injection attacks via `open()`.
Furthermore, I would recommend providing input validation on `$new_file`. As an example, you could split it into filename and file extension, validate the file extensions against an allow-list of allowed extensions and make sure that the filename is alphanumeric (if applicable to your use case). On top of that, I would recommend using the File API to check if the file to access actually exists.
Thank you,
Florian Walter